[WIP] Bugfix/list revisions activation suffix #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous pull request added support for the idea of an activationSuffix config option, so it didn't always have to be
current
. Allowing you to theoretically have many activations in one db.What I didn't take into account was fetchRevisions. This PR adds support for activationSuffix to fetchRevisions so the current revision is derived from activationSuffix.
That has been dealt with in this PR, the WIP part is: I still haven't taken into account revision trimming with multiple activated revisions. At the moment it will trim based on your activationSuffix, so if you had activated with activationSuffix
currentSpecial
in the past, you could lose it in the future if you are uploading with trimming and a different activationSuffix.Any suggestions here? You could theoretically have a key listing activation keys/suffixes but maybe there's a better way.