Skip to content

Fix the plugin return object for keep-enabled gzipping #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ module.exports = {
if (keep) {
self.log('keep is enabled, added gzipped files to `context.distFiles`', { verbose: true });
return {
distFiles: gzippedFiles,
distFiles: [].concat(gzippedFiles), // needs to be a copy
gzippedFiles: gzippedFiles
}
};
}
return { gzippedFiles: gzippedFiles };
})
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/index-nodetest.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,16 @@ describe('gzip plugin', function() {
done(reason);
});
});

it('does not use the same object for gzippedFiles and distFiles', function(done) {
return assert.isFulfilled(plugin.willUpload(context))
.then(function(result) {
assert.notStrictEqual(result.distFiles, result.gzippedFiles);
done();
}).catch(function(reason){
done(reason);
});
});
});
});
});