Skip to content

$this and $that font-lock keywords are not constrained #305

@phil-s

Description

@phil-s

https://github.com/ejmr/php-mode/blob/master/php-mode.el#L1331

 ;; Highlight special variables
 ("\\$\\(this\\|that\\)" 1 font-lock-constant-face)

This pattern matches any variable starting with $this or $that.

e.g. $this_item has the $this part incorrectly highlighted.

This particular instance is presumably fixed like so:

 ("\\$\\(this\\|that\\)\\_>" 1 font-lock-constant-face)

I haven't tried to establish whether this is an isolated issue, or indicative of a more widespread problem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions