Problem manually setting dap-python-executable

[rr326]

I have been struggling getting dap to work with my python virtual environment. As a workaround, @yyoncho suggested manually setting dap-python-executable to the full path of python.

After doing that, I get:

nil -m ptvsd --wait --host localhost --port 32000 /Users/rrosen/dev/kachess/kachess/kdata.py 
zsh:1: command not found: nil

@yyoncho found the problem. The workaround is: you may fix it by going to dap-python.el and changing line 70 to (python-executable dap-python-executable)

He thinks: The issue has been introduced probably with #105 @mpanarin

(BTW - The workaround works.)

[rr326]

Additional point - before setting the full path, dap-python was using the python of my .zshenv, even after I manually did M-x pyvenv-activate which properly sets the VIRTUAL_ENV and PATH. Perhaps virtualenv problem is related. (And note - when I view process-environment it properly shows PATH and VIRTUAL_ENV, as you'd expect.)

[yyoncho]

@rr326 can you provide more details on your python configuration.

Edit: ignore, I saw the details in the second comment.

[rr326]

I'm on OSX 10.14.6, which might matter.

[mpanarin]

@rr326 My comment may be dumb, but just in case:
Did you restart lsp workspace after activating venv?
Because, afair, lsp doesn't update itself on venv activation and this may be an issue.

[mpanarin]

additionally, do you use pyenv?
If so, I'll need to debug that part of code a bit. If not, then it fails in (executable-find dap-python-executable)

[fangherk]

I'm getting the same error as well. I use both pyenv and pyvenv, but I'm mainly working in a pyvenv environment. It seems that https://github.com/emacs-lsp/dap-mode/blob/master/dap-python.el#L49 is defaulting to finding pyenv by default if it exists, but a prompt might be more useful here.

[rr326]

@mpanarin Not sure what you mean by "restart lsp workspace". Here's what I did this time: No files open. Set virtual environment. Then open a python file which would set lsp mode. Then manually (require 'dap-python). Same outcome.

I DO use pyenv, but not in this case. (So yes, it's on my system but not activated for this direcgtory.) This directory is controlled by pipenv. But regardless, I'm manually activating the virtual environment with M-x pyvenv-activate.

Anything else I can tell you?

[yyoncho]

but a prompt might be more useful here.

Fallback to interactive python lookup sounds good in case user have some misconfiguration and dap-python is unable to find the correct binary.

Also, I think it will be good if we have a way to bypass this discovery and use directly the python binary provided in the template and then the users could create per project configurations.

[honnix]

I'm experiencing the same issue and my workaround is to override dap-python--pyenv-executable-find as:

  (defun dap-python--pyenv-executable-find (command)
    (executable-find command))

Since pyvenv sets up proper environment variables, executable-find works just fine.

Another thing to note is, without activating any virtualenv via pyvenv, (executable-find "python") results a proper shim, for example in my case $HOME/.pyenv/shims/python.