This repository was archived by the owner on Jul 8, 2023. It is now read-only.
FIX: Return static docblocks #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solved enumeration class. Fixed a broken exception reference in docblock.
Bilge
force-pushed
the
return-static-docblocks
branch
from
a8ef81e to
3df2966
Compare
|
Thanks. Had to manually merge because of out-of-date contribution guidelines (not your fault). Released in 5.1.1. |
|
Thanks, breh. Keep making awesome libraries. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes static analysis in editors such as PhpStorm. This enables calls such as
MyEnum::memberByValue($foo)to returnMyEnuminstead ofValueMultitonInterfaceduring static analysis thus avoiding warnings thatValueMultitonInterfacedoes not match the expected typeMyEnumwhenMyEnumis used as a type hint for method calls.