Allow the use of a file: uri for a database #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmwaffles
reviewed
Dec 6, 2022
Member
|
I don't see a reason to not allow this. Since it is core to sqlite. |
This change allows SQLite3 to load data from files on a read only file system using Ecto and ecto_sqlite3 which use exqlite. Looking at https://sqlite.org/uri.html I saw that I could use a file url to pass in the mode=ro and immutable=1 parameters to sqlite3 to prevent the creation of `-wal` and `-shm` files. I noticed that there were still some empty directories with names starting with `file:` appearing on my laptop. This is the least intrusive change I could make to the code to allow for `file:` uris to work. I chose to use `URI.parse/1` rather than `URI.new!/1` or `URI.new/1` as the last two functions need Elixir 1.13.
warmwaffles
reviewed
Dec 7, 2022
Comment on lines
+79
to
+80
| # In most of the test matrix the message is "attempt to write a readonly database", | ||
| # but in Elixir 1.13, OTP 23, OS windows-2019 it is "not an error". |
Member
|
Released under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows SQLite3 to load data from files on a read only file system using Ecto and ecto_sqlite3 which use exqlite.
Looking at https://sqlite.org/uri.html I saw that I could use a file url to pass in the mode=ro and immutable=1 parameters to sqlite3 to prevent the creation of
-waland-shmfiles. I noticed that there were still some empty directories with names starting withfile:appearing on my laptop.This is the least intrusive change I could make to the code to allow for
file:uris to work.I chose to use
URI.parse/1rather thanURI.new!/1orURI.new/1as the last two functions need Elixir 1.13.