Skip to content

feat: inject sigils #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

feat: inject sigils #86

merged 2 commits into from
Aug 21, 2025

Conversation

leandrocp
Copy link
Contributor

@leandrocp leandrocp commented Aug 20, 2025

Based on #75 and #84 I'm assuming it's fine to inject more sigils.

I've included ones from https://elixir-lang.org/blog/2025/08/18/interop-and-portability, https://github.com/nvim-treesitter/nvim-treesitter/blob/main/runtime/queries/elixir/injections.scm, and a couple others that seems popular.

Note that HOLO templates are not HEEx but that's the closest language, although I'm not sure about it.

Based on elixir-lang#75 and elixir-lang#84 I'm assuming it's fine to inject more sigils.

I've included ones from
https://elixir-lang.org/blog/2025/08/18/interop-and-portability and a
couple others that seems popular.
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But let's avoid adding new single letter ones due to their potential of conflict (unless they are language built-in).

@jonatanklosko jonatanklosko merged commit d24cece into elixir-lang:main Aug 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants