Skip to content

Test on OTP 24 #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Test on OTP 24 #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,19 @@ jobs:
matrix:
include:
- pair:
elixir: 1.10.4
otp: 21.3.8.21
elixir: "1.10"
otp: 21
- pair:
elixir: 1.11.4
otp: 23.3.3
elixir: "1.11"
otp: 23
- pair:
elixir: "1.12"
otp: 24
lint: lint
steps:
- uses: actions/checkout@v2

- uses: erlef/setup-elixir@v1
- uses: erlef/setup-beam@v1
with:
otp-version: ${{matrix.pair.otp}}
elixir-version: ${{matrix.pair.elixir}}
Expand Down
17 changes: 13 additions & 4 deletions test/ex_doc/formatter/html/templates_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,12 @@ defmodule ExDoc.Formatter.HTML.TemplatesTest do
content = Templates.sidebar_template(doc_config(), @empty_nodes_map)

assert content =~
~r{<div class="sidebar-header">\s*<div class="sidebar-projectDetails">\s*<a href="#{
homepage_url()
}" class="sidebar-projectName">\s*Elixir\s*</a>\s*<strong class="sidebar-projectVersion">\s*v1.0.1\s*</strong>\s*</div>\s*</div>}
~r"""
<div class="sidebar-header">\s*\
<div class="sidebar-projectDetails">\s*\
<a href="#{homepage_url()}" class="sidebar-projectName">\s*Elixir\s*</a>\s*\
<strong class="sidebar-projectVersion">\s*v1.0.1\s*</strong>\s*</div>\s*</div>\
"""
end

test "text links to main when there is no homepage_url" do
Expand All @@ -183,7 +186,13 @@ defmodule ExDoc.Formatter.HTML.TemplatesTest do
content = Templates.sidebar_template(config, @empty_nodes_map)

assert content =~
~r{<div class="sidebar-header">\s*<div class="sidebar-projectDetails">\s*<a href="hello.html" class="sidebar-projectName">\s*Elixir\s*</a>\s*<strong class="sidebar-projectVersion">\s*v1.0.1\s*</strong>\s*</div>\s*</div>}
~r"""
<div class="sidebar-header">\s*\
<div class="sidebar-projectDetails">\s*\
<a href="hello.html" class="sidebar-projectName">\s*Elixir\s*</a>\s*\
<strong class="sidebar-projectVersion">\s*v1.0.1\s*</strong>\s*\
</div>\s*</div>\
"""
end

test "enables nav link when module type have at least one element" do
Expand Down