-
Notifications
You must be signed in to change notification settings - Fork 411
Fix lost logcontext on HomeServer.shutdown()
#19108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lost logcontext on HomeServer.shutdown()
#19108
Conversation
| with PreserveLoggingContext(): | ||
| background_process.cancel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main fix!
See the Deferred callbacks section of our logcontext docs for more info (specifically using solution 2).
Heads-up, I wrote the docs too so it's my assumptions/understanding all the way down. Apply your own scrutiny.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on this!
|
Thanks for the review @anoadragon453 🦓 |
Fix lost logcontext on
HomeServer.shutdown()Same fix as #19090
Spawning from working on clean tenant deprovisioning in the Synapse Pro for small hosts project (https://github.com/element-hq/synapse-small-hosts/pull/204).
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.