-
Notifications
You must be signed in to change notification settings - Fork 412
MSC4140: finalised delayed events, and more #19038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AndrewFerr
wants to merge
12
commits into
element-hq:develop
Choose a base branch
from
AndrewFerr:msc4140-finalised-and-filters
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4fd17d4
MSC4140: finalised delayed events, and more
AndrewFerr bc0e1a3
Add changelog
AndrewFerr 4a7e78c
Work around Postgres-only error
AndrewFerr 99f8501
Rename experimental config per suggestion
AndrewFerr 96ed87a
Add description comment to new table
AndrewFerr 2ec54e4
Merge finalised_delayed_events into delayed_events
AndrewFerr 048508c
Merge with 'develop': PEP585 and always RETURNING
AndrewFerr 095eda4
Merge with 'develop': Python 3.14 support
AndrewFerr 5cd80ed
Add finalised_ts index in background
AndrewFerr 11c79c2
Include DelayedEventsStore in migrated DB stores
AndrewFerr d2aba30
Fix error code string
AndrewFerr e5bef01
Run UPDATE in transaction, and check rowcount
AndrewFerr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had to be added to pass the
check-schema-deltajob.Given that this is an index on a new, null-by-default column, is there really a need to add it in the background?