Fix backwards compat for DirectServeJsonResource
#18600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As that appears in the module API. Broke in #18595.
anoadragon453
changed the title
DirectServerJsonResourceDirectServeJsonResource
anoadragon453
requested changes
Jun 26, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
DirectServeHtmlResource is also exposed, and likely needs to be updated as well as it's also an instance of _AsyncResource?
Member
Author
Oh right, missed that due to lack of constructor 🤦 |
anoadragon453
approved these changes
Jun 26, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
LGTM assuming CI passes. Thanks for fixing it so quickly!
Member
There was a problem hiding this comment.
This is unrelated to this PR, but appears to be needed on develop after #18589. Though I'm not entirely sure why...
Fine to keep in this PR IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As that appears in the module API.
Broke in #18595.