Sliding Sync: Support filtering by 'tags' / 'not_tags' in SSS #17662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
changed the title
MadLittleMods
requested changes
Sep 11, 2024
3 tasks
MadLittleMods
added a commit
that referenced
this pull request
Sep 12, 2024
Move filters tests to rest layer in order to test the new (with sliding sync tables) and fallback paths that Sliding Sync can use. Also found a bug in the new path because it's not being tested which is also fixed in this PR. We now take into account `has_known_state` when filtering. Spawning from #17662 (comment). This should have been done when we started using the new sliding sync tables in #17630
Conflicts: tests/handlers/test_sliding_sync.py
MadLittleMods
approved these changes
Sep 12, 2024
devonh
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be enough to make Element Web work (or at least move it on to the next hurdle), although I'm not super confident in it, especially the tests since the
is_dmtests were testing a different filter method. The tests are also just at the lowest unit level rather than anything higher. I'm not sure what the difference is between the two filter methods - I guess we would need to add both?Simplified Sliding Sync (SSS)
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)