Skip to content

Revert "Improve perf of sync device lists" #17207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2024
Merged

Revert "Improve perf of sync device lists" #17207

merged 1 commit into from
May 16, 2024

Conversation

@erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented May 16, 2024

Reverts #17191

@erikjohnston erikjohnston requested a review from a team as a code owner May 16, 2024 15:07
@erikjohnston erikjohnston merged commit fd12003 into develop May 16, 2024
@erikjohnston erikjohnston deleted the revert-17191-erikj/faster_sync_devices branch May 16, 2024 15:07
MadLittleMods
MadLittleMods reviewed May 16, 2024
View reviewed changes
changelog.d/17191.misc
@@ -1 +0,0 @@
Improve performance of calculating device lists changes in `/sync`.
Copy link
Contributor

@MadLittleMods MadLittleMods May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why revert?

Are we going to port back this bug fix

Copy link
Member Author

@erikjohnston erikjohnston May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was causing some issues on matrix.org, possibly due to repeatedly sending down the same device list updates? We still need to investigate.

MadLittleMods added a commit that referenced this pull request May 16, 2024
@MadLittleMods
Fix joined_rooms/joined_room_ids usage
59da375 
This change was introduced in #17203

But then #17207 was
reverted which brought back usage `joined_rooms` that needed to be
updated. Wasn't caught because `develop` wasn't up to date before merging
@MadLittleMods MadLittleMods mentioned this pull request May 16, 2024
Merged
3 tasks
MadLittleMods added a commit that referenced this pull request May 16, 2024
@MadLittleMods
Fix joined_rooms/joined_room_ids usage (#17208)
fe07995 
This change was introduced in
#17203

But then #17207 was reverted
which brought back usage `joined_rooms` that needed to be updated.
Wasn't caught because `develop` wasn't up to date before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MadLittleMods MadLittleMods MadLittleMods left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erikjohnston @MadLittleMods