Skip to content

Use configured URL for link to desktop app in message search settings #30742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

Use configured URL for link to desktop app in message search settings #30742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c55879
Use configured URL for link to desktop app in message search settings
t3chguy Sep 11, 2025
5cbce37
Update snapshots
t3chguy Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/components/views/settings/EventIndexPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export default class EventIndexPanel extends React.Component<EmptyObject, IState

public render(): React.ReactNode {
let eventIndexingSettings: JSX.Element | undefined;
const brand = SdkConfig.get().brand;
const { brand, desktop_builds: desktopBuilds } = SdkConfig.get();

if (EventIndexPeg.get() !== null) {
eventIndexingSettings = (
Expand Down Expand Up @@ -196,11 +196,7 @@ export default class EventIndexPanel extends React.Component<EmptyObject, IState
},
{
desktopLink: (sub) => (
<ExternalLink
href="https://element.io/get-started"
target="_blank"
rel="noreferrer noopener"
>
<ExternalLink href={desktopBuilds.url} target="_blank" rel="noreferrer noopener">
{sub}
</ExternalLink>
),
Expand Down
2 changes: 1 addition & 1 deletion test/unit-tests/components/views/settings/__snapshots__/EventIndexPanel-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ exports[`<EventIndexPanel /> when event indexing is not supported renders link t
Element can't securely cache encrypted messages locally while running in a web browser. Use
<a
class="mx_ExternalLink"
href="https://element.io/get-started"
href="https://element.io/download"
rel="noreferrer noopener"
target="_blank"
>
Expand Down
2 changes: 1 addition & 1 deletion ...s/components/views/settings/tabs/user/__snapshots__/SecurityUserSettingsTab-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ exports[`<SecurityUserSettingsTab /> renders security section 1`] = `
Element can't securely cache encrypted messages locally while running in a web browser. Use
<a
class="mx_ExternalLink"
href="https://element.io/get-started"
href="https://element.io/download"
rel="noreferrer noopener"
target="_blank"
>
Expand Down
Loading