Fix: Clicking on an item in the member list causes it to scroll to the top rather than show the profile view #30455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langleyd
changed the title
dbkr
approved these changes
Aug 1, 2025
…ector-im/element-web into langleyd/fix_member_list_click_failure
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30454
The issue is caused by a conflict between the onClick handler on the item(that opens the profile) and the onFocus handler on the ListView(that makes sure the last focused roving tab item is scrolled on screen).
The fix is to stop the onFocus raised by the clicking of the item bubbling to the ListView.