This repository was archived by the owner on Oct 2, 2020. It is now read-only.
add pug support #66
Open
add pug support #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Bumping this! The current jade version relies on an old version of uglify-js that is vulnerable to the security exploit CVE-2015-8857 (jade@^1.11.0 > transformers@^2.1.0 > uglify-js@~2.2.5) |
|
+1 What do we need to do to get this merged? |
|
Would also like to see this merged :) |
|
Isn't jade a little bit outdated since the rename? Would be nice to finally be able to use pug instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull adds pug support. It is kept in a seperate file to make the process of removing jade easier. If this pull gets accepted also my pull in the electron/electron-compile repo needs to be accepted to enable pug support. This just adds
'text/pug': 'pug'to the typesToRig object in src/rig-mime-types.js.