Switch to vanilla emsdk for building pglite #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted from the *.o files of plpgsql + the already predefined ones; -sDYLINK_DEBUG=2 flag is very useful in debugging emscripten's dynamic linking; generating the EXPORTED_FUNCTIONS needs to be automated
automate creation of EXPORTED_FUNCTIONS emscripten parameter;
… on shared libs' exports
added 8 commits
September 13, 2025 17:03
…-pglite into tdrz/tryVanillaSdk
tdrz
commented
Sep 16, 2025
config.site
Outdated
| @@ -0,0 +1 @@ | |||
| ac_cv_exeext=.cjs No newline at end of file | |||
There was a problem hiding this comment.
I think this entire file can be removed, since we're passing it to configure in build-pglite.sh emconfigure ./configure ac_cv_exeext=.cjs
tdrz
commented
Sep 16, 2025
tdrz
commented
Sep 16, 2025
Comment on lines
+489
to
+490
| // tdrz: I've commented this out!!! | ||
| // stdin = fdopen(saved_stdin, "r"); |
There was a problem hiding this comment.
Why was this even needed?
tdrz
commented
Sep 16, 2025
Comment on lines
+6
to
+7
| CONTRIB_BUILD_ROOT := /tmp/extensions/build | ||
| ARCHIVE_DIR := /install/pglite/extensions |
There was a problem hiding this comment.
Hard coded final paths ... not great!
tdrz
commented
Sep 16, 2025
|
|
||
| COPY ./extern . | ||
|
|
||
| # ENV EMCC_COMMON_FLAGS="-fPIC -sWASM_BIGINT -sMIN_SAFARI_VERSION=150000 -D__PYDK__=1 -O2 -m32 -D_FILE_OFFSET_BITS=64 -sSUPPORT_LONGJMP=emscripten -mno-bulk-memory -mnontrapping-fptoint -mno-reference-types -mno-sign-ext -mno-extended-const -mno-atomics -mno-tail-call -mno-multivalue -mno-relaxed-simd -mno-simd128 -mno-multimemory -mno-exception-handling -Wno-unused-command-line-argument -Wno-unreachable-code-fallthrough -Wno-unused-function -Wno-invalid-noreturn -Wno-declaration-after-statement -Wno-invalid-noreturn" |
There was a problem hiding this comment.
I guess I wanted to look more into each of these flags to see if it makes sense to add them to libs and/or pglite.
tdrz
commented
Sep 16, 2025
Comment on lines
+109
to
+121
| $(CC) $(CFLAGS) $(LDFLAGS) -DPG_PREFIX=/tmp/pglite -DCMA_MB=12 -I$(top_builddir)/src/include -I$(top_builddir)/src/ -I$(top_builddir)/src/interfaces/libpq -o pglite.o -c $(top_builddir)/$(PGLITE_MAIN) -Wno-incompatible-pointer-types-discards-qualifiers | ||
| $(CC) \ | ||
| $(PGLITE_CFLAGS) \ | ||
| -fPIC -sWASM_BIGINT -sMIN_SAFARI_VERSION=150000 -D__PYDK__=1 -m32 -D_FILE_OFFSET_BITS=64 -sSUPPORT_LONGJMP=emscripten -mno-bulk-memory -mnontrapping-fptoint -mno-reference-types -mno-sign-ext -mno-extended-const -mno-atomics -mno-tail-call -mno-multivalue -mno-relaxed-simd -mno-simd128 -mno-multimemory -mno-exception-handling -Wno-unused-command-line-argument -Wno-unreachable-code-fallthrough -Wno-unused-function -Wno-invalid-noreturn -Wno-declaration-after-statement -Wno-invalid-noreturn \ | ||
| -DPYDK=1 -DPG_PREFIX=/tmp/pglite -DCMA_MB=12 -o pglite.html --shell-file $(top_builddir)/pglite-wasm/repl.html \ | ||
| $(PGPRELOAD) \ | ||
| -sGLOBAL_BASE=12MB -ferror-limit=1 \ | ||
| -sFORCE_FILESYSTEM=1 -sNO_EXIT_RUNTIME=1 -sENVIRONMENT=node,web,worker \ | ||
| -sMAIN_MODULE=2 \ | ||
| -sEXPORTED_FUNCTIONS=@$(emscripten_imports_dir)/exported_functions.txt \ | ||
| -sMODULARIZE=1 -sEXPORT_ES6=1 -sEXPORT_NAME=Module \ | ||
| -sALLOW_TABLE_GROWTH -sALLOW_MEMORY_GROWTH -sERROR_ON_UNDEFINED_SYMBOLS=0 \ | ||
| -sEXPORTED_RUNTIME_METHODS=$(EXPORTED_RUNTIME_METHODS) \ |
There was a problem hiding this comment.
emscripten specific flags should be moved out of Makefiles (if at all possible)
tdrz
commented
Sep 16, 2025
| -lnodefs.js -lidbfs.js -lxml2 -lz | ||
| endif | ||
|
|
||
| ifeq ($(PORTNAME), wasi) |
There was a problem hiding this comment.
We should probably cleanup WASI stuff.
tdrz
commented
Sep 16, 2025
There was a problem hiding this comment.
Is postgres.wasm target even needed?
tdrz
commented
Sep 16, 2025
tdrz
commented
Sep 16, 2025
There was a problem hiding this comment.
A good candidate for refactoring/removal
tdrz
commented
Sep 16, 2025
tdrz
commented
Sep 16, 2025
tdrz
commented
Sep 16, 2025
tdrz
commented
Sep 16, 2025
tdrz
commented
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.