Skip to content

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Nov 11, 2020

#83081 ran into an issue with typescript files being referenced by multiple ts configs, the error message isn't very useful to figuring out the problem. This improves it a little by listing the configs which are referencing the files.

before:

ERROR The following files belong to multiple tsconfig.json files listed in src/dev/typescript/projects.ts
       - x-pack/typings/elasticsearch/aggregations.ts
       - x-pack/typings/elasticsearch/index.ts

after:

ERROR The following files belong to multiple tsconfig.json files listed in src/dev/typescript/projects.ts
      - x-pack/typings/elasticsearch/aggregations.ts:
        - x-pack/tsconfig.json
        - x-pack/test/tsconfig.json
        - x-pack/examples/ui_actions_enhanced_examples/tsconfig.json
      - x-pack/typings/elasticsearch/index.ts:
        - x-pack/tsconfig.json
        - x-pack/test/tsconfig.json
        - x-pack/examples/ui_actions_enhanced_examples/tsconfig.json

@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.10.0 v7.11.0 v8.0.0 labels Nov 11, 2020
@spalger spalger marked this pull request as ready for review November 11, 2020 20:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger requested a review from a team November 11, 2020 20:19
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 2f26eaf into elastic:master Nov 11, 2020
@spalger spalger deleted the implement/better-ts-project-error-message branch November 11, 2020 22:09
spalger added a commit to spalger/kibana that referenced this pull request Nov 11, 2020
spalger added a commit to spalger/kibana that referenced this pull request Nov 11, 2020
spalger added a commit that referenced this pull request Nov 11, 2020
spalger added a commit that referenced this pull request Nov 11, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 12, 2020
…ts-public

* upstream/master: (57 commits)
  Remove unused asciidoc file (elastic#83228)
  [Lens] Remove background from lens embeddable (elastic#83061)
  [Discover] Unskip flaky tests based on discover fixture index pattern (elastic#82991)
  Removing unnecessary trailing slash in CODEOWNERS
  Trying to fix CODEOWNERS again, where was a non-existent team prior (elastic#83236)
  Trying to fix CODEOWERS, missing a starting slash (elastic#83233)
  skip flaky suite (elastic#83231)
  Add enzyme rerender test helper (elastic#83208)
  Move Elasticsearch type definitions out of APM (elastic#83081)
  [ts/checkTsProjects] produce a more useful error message (elastic#83209)
  [kbnClient] retry updating config if necessary (elastic#83205)
  I accidentally removed this line in a recent PR (elastic#83201)
  Don't make the caller do work the function can do (elastic#83180)
  [App Search] Update EngineRouter & EngineNav to use EngineLogic (elastic#83138)
  [Workplace Search] Add routes for Sources (elastic#83125)
  Update logstash pipeline management to use system index APIs (elastic#80405)
  [ML] Replace EuiBasicTable with EuiInMemoryTable (elastic#83057)
  [Metrics UI] Add basic interaction and shell for node details overlay (elastic#82013)
  [App Search] Added the log retention confirmation modal to the Settings page (elastic#83009)
  [docs] Fix create map title in import geospatial page (elastic#83172)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.10.0 v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants