[SR] Adjust endpoints for ES 8.0 snapshot API changes #39533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
chore
non-issue
Contributor
|
Pinging @elastic/es-ui |
jen-huang
changed the title
Contributor
💔 Build Failed |
Contributor
Author
|
Failing on unrelated dashboard test. |
Contributor
Author
|
Retest |
Contributor
💚 Build Succeeded |
alisonelizabeth
approved these changes
Jun 25, 2019
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
Tested locally, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust snapshot and repositories endpoint to account for changes in the response of ES APIs: elastic/elasticsearch#42090
When running a recent 8.0 snapshot version of ES and Kibana without this PR, parts of SR breaks, most notably the list of snapshots does not load and inaccurately shows a message about errors with repositories. This PR fixes that and other places in SR where snapshot information is retrieved.
(cc @cjcenizal since you ran into these issues first!)
Note: The ES API changes are breaking and only target 8.0, so this PR will be the same and will NOT be backported.