[CPS][Discover] Add CPS support to Discover sessions #244465
Draft
+1,753
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion_tests/ci_checks
…gin-cps2 # Conflicts: # src/platform/plugins/shared/dashboard/server/api/dashboard_state_schemas.ts
…tion_tests/ci_checks
…tion_tests/ci_checks
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the ability to react to CPS changes and store and restore project routing settings in Discover sessions.
Main Features Added:
- Added a new toggle switch in the save dialog to "Store project routing with Discover session"
- Similar to the existing "Store time with Discover session" option
- Only shown when project routing is available (hasProjectRouting)
- Added dependency on the cps (Cross-Project Search) plugin
- Syncs project routing between internal state and CPS manager
- Subscribes to project routing changes from CPS manager and triggers data fetches
- Passes projectRouting parameter to search source when executing searches
- Ensures project routing is applied to query execution
- Monitors globalState.projectRouting changes and triggers data fetches
- Updates services when switching tabs or when global state changes
- Keeps project routing in sync across tabs
- Modified save/restore to conditionally persist projectRouting based on projectRoutingRestore flag
- Falls back to current tab's project routing when copying sessions
- Added debug logging for troubleshooting
Key Design Decision:
Project routing is NOT synced to URL (unlike time range and filters), only stored in saved objects
(discover_app_state_container.ts:220). This keeps URLs cleaner while still allowing the feature to be persisted in
saved sessions.