Add support for changing index settings during restore process #9285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
:Distributed Coordination/Snapshot/Restore
Member
There was a problem hiding this comment.
"should indices an inner object" is missing a word I think
Member
|
@imotov left some comments :) |
Contributor
Author
|
@dakrone pushed some changes to address your comments |
Member
There was a problem hiding this comment.
A 5 millisecond refresh interval won't cause too much load on Jenkins?
Contributor
Author
There was a problem hiding this comment.
Good catch. I will fix that.
Member
|
LGTM, left one comment with a question |
imotov
force-pushed
the
issue-7887-change-settings-on-restore
branch
from
4f9d637 to
c0da353
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7887