Empty mapping to hold null meta #72709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With elastic#72616 we have changed the way that empty mappings are created for an index. Accidentally such mappings have been created with an empty meta map instead of null, which causes test failures in tests that compare mappings and are now finding an unexpected empty meta object which was not there before. This commit fixes the empty mapping to not hold any meta, replacing the empty map with a null argument.
javanna
added
>test
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
May 4, 2021
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM. Maybe add a specific test to check serialization of the empty mapper?
Member
Author
|
@romseygeek I pushed a test, and I also fixed the empty mappipng lookup to hold null meta instead of empty map. |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
May 4, 2021
With elastic#72616 we have changed the way that empty mappings are created for an index. Accidentally such mappings have been created with an empty meta map instead of null, which causes test failures in tests that compare mappings and are now finding an unexpected empty meta object which was not there before. This commit fixes the empty mapping to not hold any meta, replacing the empty map with a null argument.
javanna
added a commit
that referenced
this pull request
May 4, 2021
With #72616 we have changed the way that empty mappings are created for an index. Accidentally such mappings have been created with an empty meta map instead of null, which causes test failures in tests that compare mappings and are now finding an unexpected empty meta object which was not there before. This commit fixes the empty mapping to not hold any meta, replacing the empty map with a null argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #72616 we have changed the way that empty mappings are created for an index. Accidentally such mappings have been created with an empty meta map instead of null, which causes test failures in tests that compare mappings and are now finding an unexpected empty meta object which was not there before.
This commit fixes the empty mapping to not hold any meta, replacing the empty map with a null argument.