Save Shard ID Serializations in Bulk Requests (#56209) #58414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like elastic#56094 but for the request side. Removes a lot of redundant `ShardId` instances from bulk shard requests as well as stops serializing index names when they're not needed because they're not different from what is in the shard id. Even ignoring the index name serialization savings here, this change saves one `ShardId` instance per bulk shard request at least. This means it saves approximately: * 8 bytes for the `ShardId` object (itself + one field) * + another 4 bytes for the `int` in the `ShardId` * 16 bytes (two fields + the instance itself + the padding) for the `Index` object * + 30 bytes for the `Index` uuid string * + all the bytes in the index name string => 60+ bytes per bulk request item saved on heap and over the wire
original-brownbear
added
:Distributed Indexing/CRUD
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
elasticmachine
added
the
Team:Distributed (Obsolete)
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 23, 2020
Disabling BwC tests so that elastic#58414 can be merged.
Contributor
Author
|
Jenkins run elasticsearch-ci/1 (dep download issue) |
original-brownbear
added a commit
that referenced
this pull request
Jun 23, 2020
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 23, 2020
Now that elastic#58414 has been merged, reenabling BwC tests
original-brownbear
added a commit
that referenced
this pull request
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like #56094 but for the request side.
Removes a lot of redundant
ShardIdinstances from bulk shard requests as well as stops serializing index names when they're not needed because they're not different from what is in the shard id.Even ignoring the index name serialization savings here, this change saves one
ShardIdinstance per bulk shard request at least. This means it saves approximately:ShardIdobject (itself + one field)intin theShardIdIndexobjectIndexuuid string=> 60+ bytes per bulk request item saved on heap and over the wire
backport of #56209