Stop Redundantly Serializing ShardId in BulkShardResponse (#56094) #56866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original-brownbear
added
:Distributed Indexing/CRUD
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
elasticmachine
added
the
Team:Distributed (Obsolete)
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 17, 2020
Mute BwC tests so elastic#56866 can be merged.
original-brownbear
added a commit
that referenced
this pull request
May 17, 2020
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 17, 2020
Reenable BwC tests now that elastic#56866 is merged.
original-brownbear
added a commit
that referenced
this pull request
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading/writing the individual doc responses in the context
of a bulk shard response there is no need to serialize the
ShardIdover and over. This can waste a lot of memory when handling large bulk
requests.
backport of #56094