Remove Redundant Cluster State during Snapshot INIT + Master Failover (#54420) #55208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elastic#54420) * Remove Redundant Cluster State during Snapshot INIT + Master Failover Similar to elastic#54395 we know that a snapshot in INIT state has not written anything to the repository yet. If we see one from a master failover, there is no point in moving it to ABORTED before removing it from the cluster state in a subsequent CS update. Instead, we can simply remove its job from the CS the first time we see it on master failover and be done with it.
original-brownbear
added
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Contributor
Author
|
Jenkins run elasticsearch-ci/2 (some ML issue) |
1 similar comment
Contributor
Author
|
Jenkins run elasticsearch-ci/2 (some ML issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #54395 we know that a snapshot in INIT state has not
written anything to the repository yet. If we see one from a master
failover, there is no point in moving it to ABORTED before removing it
from the cluster state in a subsequent CS update.
Instead, we can simply remove its job from the CS the first time
we see it on master failover and be done with it.
backport of #54420
Note: for the backport we need to keep the cleanup code because in a mixed cluster containing 6.x we could have still written data to the repo on INIT so we set the flag for the cleanup to true on the bwc path