Guess root cause support unwrap #50525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticsearchException.guessRootCauses would return wrapper exception if inner exception was not an ElasticsearchException. Fixed to never return wrapper exceptions. Relates elastic#50417
henningandersen
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
pugnascotia
approved these changes
Jan 6, 2020
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jan 8, 2020
ElasticsearchException.guessRootCauses would return wrapper exception if inner exception was not an ElasticsearchException. Fixed to never return wrapper exceptions. At least following APIs change root_cause.0.type as a result: _update with bad script _index with bad pipeline Relates elastic#50417
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jan 8, 2020
testFailureToAndFromXContentWithDetails had incorporated that guessRootCauses returned the wrapper when the underlying exception was not an ElasticsearchException, fixed. Relates elastic#50525
henningandersen
added a commit
that referenced
this pull request
Jan 8, 2020
testFailureToAndFromXContentWithDetails had incorporated that guessRootCauses returned the wrapper when the underlying exception was not an ElasticsearchException, fixed. Relates #50525
henningandersen
added a commit
that referenced
this pull request
Jan 8, 2020
ElasticsearchException.guessRootCauses would return wrapper exception if inner exception was not an ElasticsearchException. Fixed to never return wrapper exceptions. At least following APIs change root_cause.0.type as a result: _update with bad script _index with bad pipeline Relates #50417
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jan 8, 2020
Removed workaround for guessRootCauses returning wrapper. Relates elastic#50525 and elastic#50417
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
ElasticsearchException.guessRootCauses would return wrapper exception if inner exception was not an ElasticsearchException. Fixed to never return wrapper exceptions. At least following APIs change root_cause.0.type as a result: _update with bad script _index with bad pipeline Relates elastic#50417
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
testFailureToAndFromXContentWithDetails had incorporated that guessRootCauses returned the wrapper when the underlying exception was not an ElasticsearchException, fixed. Relates elastic#50525
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElasticsearchException.guessRootCauses would return wrapper exception if
inner exception was not an ElasticsearchException. Fixed to never return
wrapper exceptions.
At least following APIs change
root_cause.0.typeas a result:_updatewith bad script_indexwith bad pipelineRelates #50417
Specifically, the need to unwrap here:
2d16e55#diff-13682f098a7ed5c260bb21049e9efd55R88
is that we do not guess root cause correctly for wrapped exceptions.
Marking this as bugfix since it fixes the root_cause of a few APIs.