Skip to content

Conversation

@polyfractal
Copy link
Contributor

Phew! :)

Note: this is targeting 7.0 branch

@polyfractal polyfractal added >docs General docs changes :Docs labels Apr 9, 2019
@polyfractal polyfractal requested a review from lcawl April 9, 2019 20:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds successfully


Authentication::
* Security: remove wrapping in put user response {pull}33512[#33512] (issue: {issue}32332[#32332])
* Enhance Invalidate Token API {pull}35388[#35388] (issues: {issue}34556[#34556], {issue}35115[#35115])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #35388 is not a breaking change. Rather, it should be under "enhancements"

Authentication::
* Security: remove wrapping in put user response {pull}33512[#33512] (issue: {issue}32332[#32332])
* Enhance Invalidate Token API {pull}35388[#35388] (issues: {issue}34556[#34556], {issue}35115[#35115])
* Remove bwc logic for token invalidation {pull}36893[#36893] (issue: {issue}36727[#36727])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkakavas Should this be described in the Breaking changes documentation (https://www.elastic.co/guide/en/elasticsearch/reference/7.0/breaking-changes-7.0.html) ?

Aggregations::
* Remove support for deprecated params._agg/_aggs for scripted metric aggregations {pull}32979[#32979] (issues: {issue}29328[#29328], {issue}31597[#31597])
* Percentile/Ranks should return null instead of NaN when empty {pull}30460[#30460] (issue: {issue}29066[#29066])
* Render sum as zero if count is zero for stats aggregation {pull}27193[#27193] (issue: {issue}26893[#26893])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see documentation for #27193 in the Breaking Changes docs

* Remove implicit index monitor privilege {pull}37774[#37774]

CCR::
* Change get autofollow patterns API response format {pull}36203[#36203] (issue: {issue}36049[#36049])
Copy link
Contributor

@lcawl lcawl Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think info about #36203 missing from the Breaking changes page too. Unless it's only a breaking change in 6.x?


CCR::
* Change get autofollow patterns API response format {pull}36203[#36203] (issue: {issue}36049[#36049])
* Follow stats api should return a 404 when requesting stats for a non existing index {pull}37220[#37220] (issue: {issue}37021[#37021])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, not sure if this is a valid breaking change in 6.7, 7.0 or neither: #37220

@polyfractal polyfractal merged commit 8ed6bd5 into elastic:7.0 Apr 10, 2019
polyfractal added a commit that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants