Remove version conditionals from InternalAggregations #40193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version conditionals are no longer needed once elastic#40177 is back-ported all the way to 6.7.
Relates to elastic#40177
javanna
added
:Analytics/Aggregations
Collaborator
|
Pinging @elastic/es-analytics-geo |
jimczi
approved these changes
Mar 19, 2019
| out.writeNamedWriteableList((List<InternalAggregation>)aggregations); | ||
| //TODO update version after backport | ||
| if (out.getVersion().onOrAfter(Version.V_8_0_0)) { | ||
| out.writeNamedWriteableList(topLevelPipelineAggregators); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version conditionals are no longer needed once #40177 is back-ported all the way to 6.7.
We need to disable bwc tests until the #40177 is backported as it requires a change in the way we serialize
InternalAggregations.