Reduce logging noise when stepping down as master before state recovery #39950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>non-issue
v7.0.0
:Distributed Coordination/Cluster Coordination
|
Pinging @elastic/es-distributed |
61 tasks
andrershov
reviewed
Mar 12, 2019
|
|
||
| @Override | ||
| public void onNoLongerMaster(String source) { | ||
| logger.debug("stepped down as master before recovering state [{}]", source); |
There was a problem hiding this comment.
Why do not we call resetRecoveredFlags here?
DaveCTurner
requested changes
Mar 12, 2019
|
|
||
| @Override | ||
| public void onNoLongerMaster(String source) { | ||
| logger.debug("stepped down as master before recovering state [{}]", source); |
There was a problem hiding this comment.
I think this needs a call to resetRecoveredFlags() too.
| // that resets it to false while a new recover is already running? | ||
| GatewayService.this.onFailure("state recovery failed: " + e.getMessage()); | ||
| logger.warn("state recovery failed", e); | ||
| resetRecoveredFlags(); |
There was a problem hiding this comment.
Should we resetRecoveredFlags() on failure of the scheduled task a few lines above this too?
There was a problem hiding this comment.
sure, added in 9de5c0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the logging noise from the state recovery component when there are duelling elections.
Relates to #32006