[ML-DataFrame] Add _preview endpoint #38924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
hendrikmuhs
reviewed
Feb 15, 2019
...-tests/src/test/java/org/elasticsearch/xpack/dataframe/integration/DataFramePivotRestIT.java
Outdated
Show resolved
Hide resolved
|
I will have a closer look on monday, due to #38934 I suggest to put this on hold for now. Good work, I like to see it in action. |
Member
Author
|
This is blocked by #38934. will have to merge into master once that is done. |
benwtrent
force-pushed
the
feature/fib-preview-api
branch
from
d9d69ba to
d63cd99
Compare
hendrikmuhs
reviewed
Feb 20, 2019
...-tests/src/test/java/org/elasticsearch/xpack/dataframe/integration/DataFramePivotRestIT.java
Outdated
Show resolved
Hide resolved
...-tests/src/test/java/org/elasticsearch/xpack/dataframe/integration/DataFramePivotRestIT.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/xpack/dataframe/action/PreviewDataFrameTransformAction.java
Outdated
Show resolved
Hide resolved
hendrikmuhs
approved these changes
Feb 21, 2019
hendrikmuhs
left a comment
hendrikmuhs
left a comment
There was a problem hiding this comment.
LGTM, I suggest a small simplification
.../src/main/java/org/elasticsearch/xpack/dataframe/action/PreviewDataFrameTransformAction.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/xpack/dataframe/action/PreviewDataFrameTransformAction.java
Show resolved
Hide resolved
|
still LGTM |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 22, 2019
* [DATA-FRAME] add preview endpoint * adjusting preview tests and fixing parser * adjusing preview transport * remove unused import * adjusting test * Addressing PR comments * Fixing failing test and adjusting for pr comments * fixing integration test
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
* [DATA-FRAME] add preview endpoint * adjusting preview tests and fixing parser * adjusing preview transport * remove unused import * adjusting test * Addressing PR comments * Fixing failing test and adjusting for pr comments * fixing integration test
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
* [DATA-FRAME] add preview endpoint * adjusting preview tests and fixing parser * adjusing preview transport * remove unused import * adjusting test * Addressing PR comments * Fixing failing test and adjusting for pr comments * fixing integration test
benwtrent
added a commit
that referenced
this pull request
Feb 22, 2019
* [DATA-FRAME] add preview endpoint * adjusting preview tests and fixing parser * adjusing preview transport * remove unused import * adjusting test * Addressing PR comments * Fixing failing test and adjusting for pr comments * fixing integration test
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
_data_frame/transforms/_previewendpoint that accepts a config definition and returns what the doc source's will be when it is ran.