Fix primary term in testAddOrRenewRetentionLease #38239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should increase primary term before renewing leases; otherwise, the term of the latest RetentionLeases will be lower than the current term.
dnhatn
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 2, 2019
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 2, 2019
Member
dnhatn
added a commit
that referenced
this pull request
Feb 2, 2019
dnhatn
added a commit
that referenced
this pull request
Feb 2, 2019
Member
Author
|
Thanks @jasontedor. |
dnhatn
added a commit
that referenced
this pull request
Feb 2, 2019
We should increase primary term before renewing leases; otherwise, the term of the latest RetentionLeases will be lower than the current term. Backport of #38239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should increase primary term before renewing leases; otherwise, the
term of the latest RetentionLeases will be lower than the current term.
Relates #37951