Fix build on sles with new docker version #36707
Conversation
|
Pinging @elastic/es-core-infra |
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left a couple of comments.
| } | ||
|
|
||
| protected static void checkDockerVersionRecent(String dockerVersion) { | ||
| final Matcher matcher = dockerVersion =~ /Docker version (\d+\.\d+)\.\d+(?:-ce)?, build [0-9a-f]{7,}/ |
There was a problem hiding this comment.
Since this is a SHA-1 hash, it can go up to 40 characters, so can we restrict this to {7,40}?
| } | ||
|
|
||
| @Test(expected = GradleException.class) | ||
| public void checkDockerVersionRecentOl() { |
There was a problem hiding this comment.
There is a typo in the name of this test: checkDockerVersionRecentOl. I have a question about the name of the tests in general. How about testPassingDockerVersions and testFailingDockerVersions?
|
@elasticmachine run gradle tests 1 |
|
@elasticmachine run gradle build tests 1 |
1 similar comment
|
@elasticmachine run gradle build tests 1 |
|
@elasticmachine run gradle build tests 1 |
|
I think this should be backported to 6.x and 6.6 too, as the same problem is failing some builds on those branches? Or is there a reason why the fix would need to be different on these branches? |
The build hash for some Docker versions is longer than 7 characters. Closes #36414
The build hash for some Docker versions is longer than 7 characters. Closes #36414
6 participants
The build hash for this version is longer,
Closes #36414