[ILM] TEST: fix long overflow in TimeValueScheduleTests #36384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>test
Collaborator
|
Pinging @elastic/es-core-features |
gwbrown
reviewed
Dec 7, 2018
| public void setUpStartAndInterval() { | ||
| // start with random epoch between 1/1/1970 and 31/12/2035 so that start is not | ||
| // so large such that (start + interval) > Long.MAX | ||
| start = randomLongBetween(0, 2082672000000L); |
Contributor
There was a problem hiding this comment.
Maybe I'm missing something but I don't quite get the math here - this number + 10,000 days (from createRandomTimeValue) is way less than Long.MAX (2^63 - 1)? Are you just giving it plenty of headroom?
Contributor
Author
There was a problem hiding this comment.
yeah, why not be more restrictive :). doing randomNonnegativeLong was too large of a range
Contributor
Author
There was a problem hiding this comment.
thought I would leave a comment to explain why the magic numbers
Contributor
There was a problem hiding this comment.
Alright, cool - I just read this the first time as saying it had to be 31/12/2035 (or less) to prevent an overflow, rather than that being somewhat arbitrary.
gwbrown
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing here because the trigger time overflowed to the point that it was negative.
Closes #35948.