Fix line length for bootstrap/client/discovery/gateway files #34905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the checkstyle suppressions for files in org.elasticsearch.bootstrap/client/discovery/gateway packages. Relates to elastic#34884
imotov
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra |
33 tasks
nik9000
approved these changes
Oct 26, 2018
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
I left two little things but LGTM regardless.
| // visible for testing | ||
| public static class NodeRemovalClusterStateTaskExecutor implements ClusterStateTaskExecutor<NodeRemovalClusterStateTaskExecutor.Task>, ClusterStateTaskListener { | ||
| public static class NodeRemovalClusterStateTaskExecutor implements ClusterStateTaskExecutor<NodeRemovalClusterStateTaskExecutor.Task>, | ||
| ClusterStateTaskListener { |
Member
There was a problem hiding this comment.
Could you indent this one more time? I'd probably also add the line break before implements rather than after the , so it is more obvious what is up when you scan file.
| enforceRecoverAfterTime = true; | ||
| reason = "expecting [" + expectedDataNodes + "] data nodes, but only have [" + nodes.getDataNodes().size() + "]"; | ||
| } else if (expectedMasterNodes != -1 && (nodes.getMasterNodes().size() < expectedMasterNodes)) { // does not meet the expected... | ||
| } else if (expectedMasterNodes != -1 && (nodes.getMasterNodes().size() < expectedMasterNodes)) { // does not meet the |
Member
There was a problem hiding this comment.
Maybe move the whole comment into the block?
imotov
added a commit
that referenced
this pull request
Oct 26, 2018
Removes the checkstyle suppressions for files in org.elasticsearch.bootstrap/client/discovery/gateway packages. Relates to #34884
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Removes the checkstyle suppressions for files in org.elasticsearch.bootstrap/client/discovery/gateway packages. Relates to #34884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the checkstyle suppressions for files in
org.elasticsearch.bootstrap/client/discovery/gateway packages.
Relates to #34884