Skip to content

Increase the length of randomly generated field #34857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2018
Merged

Increase the length of randomly generated field #34857

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf138f0
Increase the length of randomly generated field
mayya-sharipova Oct 25, 2018
52f62ed
check duplicate before adding to list and retry
mayya-sharipova Oct 25, 2018
23dc5eb
Use randomValueOtherThanMany for the test
mayya-sharipova Oct 26, 2018
8602c5c
Merge remote-tracking branch 'upstream/master' into correct-TermVecto…
mayya-sharipova Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rest-high-level/src/test/java/org/elasticsearch/client/core/TermVectorsResponseTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,14 +158,14 @@ private TermVectorsResponse.TermVector randomTermVector(boolean hasFieldStatisti
terms.add(randomTerm(hasTermStatistics, hasScores, hasOffsets, hasPositions, hasPayloads));
}

TermVectorsResponse.TermVector tv = new TermVectorsResponse.TermVector("field" + randomAlphaOfLength(2), fs, terms);
TermVectorsResponse.TermVector tv = new TermVectorsResponse.TermVector("field" + randomAlphaOfLength(7), fs, terms);
Copy link
Member

@nik9000 nik9000 Oct 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be nice to check for duplicated before adding to the list and retry. Or to pass in a unique prefix to this method to be sure we don't have duplicates.

return tv;
}

private TermVectorsResponse.TermVector.Term randomTerm(boolean hasTermStatistics, boolean hasScores,
boolean hasOffsets, boolean hasPositions, boolean hasPayloads) {

String termTxt = "term" + randomAlphaOfLength(2);
String termTxt = "term" + randomAlphaOfLength(7);
int termFreq = randomInt(10000);
Integer docFreq = null;
Long totalTermFreq = null;
Expand Down