[X-Pack] Beats centralized management: security role + licensing #34305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#30520) * Adding Beats x-pack plugin + index templates * Adding built-in roles for Beats central management * Fixing typo * Refactoring: extract common code into method * More refactoring for more code reuse * Use a single index for Beats management * Rename "fragment" to "block" * Adding configuration block type * Expand kibana_system role to include Beats management index privileges * Fixing syntax * Adding test * Adding asserting for reserved role * Fixing privileges * Updating template * Removing beats plugin * Fixing tests * Fixing role variable name * Fixing assertions * Switching to preferred syntax for boolean false checks * Making class final * Making variables final * Updating Basic license message to be more accurate
ycombinator
added
review
:Security/Authorization
Collaborator
|
Pinging @elastic/es-security |
Collaborator
|
Pinging @elastic/beats |
26 tasks
|
It seems there are some issues in the testing code, probably something changed? |
ruflin
reviewed
Oct 5, 2018
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM but someone from the ES team should also have a look.
|
@ycombinator 🎉 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #30520 to
6.x. Original description:Resolves #30493.
This PR adds:
beats_adminthat provides unfettered access to the.management-beatsindex. The purpose of this index is to store configuration and other peripheral information to make the Beats Centralized Management feature work.