Add support for 'ack watch' to the HLRC. #33962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra |
98 tasks
jtibshirani
force-pushed
the
ack-watch
branch
from
9fb51b0 to
c4c52ff
Compare
hub-cap
approved these changes
Oct 2, 2018
Contributor
hub-cap
left a comment
hub-cap
left a comment
There was a problem hiding this comment.
LGTM, 1 nit then you can merge :)
|
|
||
| @Override | ||
| public Optional<ValidationException> validate() { | ||
| ValidationException exception = new ValidationException(); |
Contributor
There was a problem hiding this comment.
We should try to put all the validation we can into the constructors themselves, because this layer of validation, while it does work, does not tell you where the actual error in setting a bad value came from. There are a lot of requireNotNull in constructors, so lets move any logic possible into therm
jtibshirani
added a commit
that referenced
this pull request
Oct 4, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #29827.