Switch WritePipelineResponse to AcknowledgedResponse #32722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously discussed moving the classes extending `AcknowledgedResponse` to simply use `AcknowledgedResponse`, making the class non-abstract. This moves the first class to do this, removing `WritePipelineResponse` in the process. If we like the way this looks, I will switch the remaining classes over to using `AcknowledgedResponse`.
dakrone
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra |
dakrone
added a commit
that referenced
this pull request
Aug 8, 2018
We previously discussed moving the classes extending `AcknowledgedResponse` to simply use `AcknowledgedResponse`, making the class non-abstract. This moves the first class to do this, removing `WritePipelineResponse` in the process. If we like the way this looks, I will switch the remaining classes over to using `AcknowledgedResponse`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously discussed moving the classes extending
AcknowledgedResponsetosimply use
AcknowledgedResponse, making the class non-abstract.This moves the first class to do this, removing
WritePipelineResponsein theprocess.
If we like the way this looks, I will switch the remaining classes over to using
AcknowledgedResponse.