-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Remove legacy MetaDataStateFormat #31603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ywelsch
merged 6 commits into
elastic:master
from
ywelsch:remove-legacy-metadatastateformat
Jun 27, 2018
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c7011a6
Remove legacy MetaDataStateFormat
ywelsch ec76043
fix tests
ywelsch 88eac6f
Remove more legacy stuff
ywelsch 649f2f2
expectThrows
ywelsch da6350b
fix test that failed because it used legacy format
ywelsch ba97446
remove legacy indices
ywelsch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,16 +81,16 @@ protected Settings prepareBackwardsDataDir(Path backwardsIndex) throws IOExcepti | |
| return builder.build(); | ||
| } | ||
|
|
||
| public void testUpgradeStartClusterOn_0_20_6() throws Exception { | ||
| String indexName = "unsupported-0.20.6"; | ||
| public void testUpgradeStartClusterOn_2_4_5() throws Exception { | ||
| String indexName = "unsupported-2.4.5"; | ||
|
|
||
| logger.info("Checking static index {}", indexName); | ||
| Settings nodeSettings = prepareBackwardsDataDir(getBwcIndicesPath().resolve(indexName + ".zip")); | ||
| try { | ||
| internalCluster().startNode(nodeSettings); | ||
| fail(); | ||
| } catch (Exception ex) { | ||
| assertThat(ex.getCause().getCause().getMessage(), containsString(" was created before v2.0.0.beta1 and wasn't upgraded")); | ||
| assertThat(ex.getCause().getCause().getMessage(), containsString("Format version is not supported")); | ||
|
||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any of the other
unsupported-x.x.x.zipfiles used?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not as far as I can see (running the tests will confirm). I initially wanted to remove those in a follow-up, but I think we can do it as well in this PR.