Skip to content

Conversation

@talevy
Copy link
Contributor

@talevy talevy commented Jun 18, 2018

This is a backport of #30942 (as well as the bugfix: 5b94afd)

for introducing is-write-index to aliases

This commit adds the is-write-index flag for aliases.
It allows requests to set the flag, and responses to display the flag.
It does not validate and/or affect any indexing/getting/updating behavior
of Elasticsearch -- this will be done in a follow-up PR.

This is a follow-up to: #30703
It made more sense to split the above PR into two PRs. One for introducing the is_write_index
flag, and another to use it for validation and index resolution.

@talevy talevy added :Data Management/Indices APIs APIs to create and manage indices and templates v6.4.0 labels Jun 18, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

talevy and others added 2 commits June 19, 2018 11:15
This commit adds the is-write-index flag for aliases.
It allows requests to set the flag, and responses to display the flag.
It does not validate and/or affect any indexing/getting/updating behavior
of Elasticsearch -- this will be done in a follow-up PR.
@talevy talevy requested review from bleskes and colings86 June 19, 2018 22:03
@bleskes
Copy link
Contributor

bleskes commented Jun 20, 2018

@talevy anything here different from #30942? I want to know where to focus on.

@talevy
Copy link
Contributor Author

talevy commented Jun 20, 2018

no. just thought I would open a PR to include Albert’s change and see if CI is happy. Since I made a PR, I figured I should get someone’s blessing. no changes

Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then :)

@talevy talevy merged commit 196ddbf into elastic:6.x Jun 20, 2018
@talevy talevy deleted the 6x-write-index branch June 20, 2018 15:26
dnhatn added a commit that referenced this pull request Jun 20, 2018
* 6.x:
  [DOCS] Omit shard failures assertion for incompatible responses  (#31430)
  [DOCS] Move licensing APIs to docs (#31445)
  backport of: add is-write-index flag to aliases (#30942) (#31412)
  backport of: Add rollover-creation-date setting to rolled over index (#31144) (#31413)
  [Docs] Extend Homebrew installation instructions (#28902)
  [Docs] Mention ip_range datatypes on ip type page (#31416)
  Multiplexing token filter (#31208)
  Fix use of time zone in date_histogram rewrite (#31407)
  Revert "Mute DefaultShardsIT#testDefaultShards test"
  [DOCS] Fixes code snippet testing for machine learning (#31189)
  Security: fix joining cluster with production license (#31341)
  [DOCS] Updated version in Info API example
  [DOCS] Moves the info API to docs (#31121)
  Revert "Increasing skip version for failing test on 6.x"
  Preserve response headers on cluster update task (#31421)
  [DOCS] Add code snippet testing for more ML APIs (#31404)
  Docs: Advice for reindexing many indices (#31279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Indices APIs APIs to create and manage indices and templates >non-issue v6.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants