Limit the analyzed text for highlighting (#27934) #28176
Conversation
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Thanks @mayya-sharipova , I left some comments
There was a problem hiding this comment.
is this change coming from another pr ?
There was a problem hiding this comment.
@jimczi this is a typo noticed by someone else, I thought I would include this correction here as well. Let me know if I should not do that.
There was a problem hiding this comment.
There is a pr open for this typo so we should use it rather than adding this in a pr that targets 6.x only.
There was a problem hiding this comment.
I think we should have a custom validator to throw an exception when the value is set to 0. Otherwise this would fail the upgrade to 7 where 0 is forbidden.
mayya-sharipova
force-pushed
the
limit-analyzed-text-for-highlight2
branch
from
bf58c2e to
47c59a5
Compare
- Introduce index level setting "index.highlight.max_analyzed_offset" to control the max number of character to be analyzed for highlighting - Make this setting to be unset by default (equal to -1) - Issue a deprecation warning if setting is unset and analysis is required on a text larger than ES v.7.x max setting (10000) - Throw IllegalArgumentException is setting is set by a user, and analysis is required on a text larger than the user's set value. Closes elastic#27517 Adding validator for index.highlight.max_analyzed_offset setting
mayya-sharipova
force-pushed
the
limit-analyzed-text-for-highlight2
branch
from
47c59a5 to
2e9f31e
Compare
| throw new IllegalArgumentException( | ||
| "[" + MAX_ANALYZED_OFFSET_SETTING.getKey() + "] must be >= 1"); | ||
| } | ||
| this.maxAnalyzedOffset = maxAnalyzedOffset; |
There was a problem hiding this comment.
@jimczi I have added a custom validator here, as you suggested. This should guard against setting value <1. Can you please continue the reviewing when you have available time.
clintongormley
added
>enhancement
:Search Relevance/Analysis
3 participants
to control the max number of character to be analyzed for highlighting
on a text larger than ES v 7.x max setting (10000)
analysis is required on a text larger than the user's set value.
Closes #27517