Skip to content

Conversation

@alexshadow007
Copy link
Contributor

Add fuzzy_transpositions parameter to multi_match and query_string queries.
Add fuzzy_transpositions, fuzzy_prefix_length and fuzzy_max_expansions
parameters to simple_query_string query.
Add transpositions parameter to doc for fuzzy query.

Closes #18348

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexshadow007 !
I left a minor comment but the pr looks good.
I'll let the CI run on this and will merge if it doesn't complain. I also think that it can be merged to 6.x since it's just a new option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say "set false to disable fuzzy transpositions" because the default is true ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@jimczi
Copy link
Contributor

jimczi commented Oct 4, 2017

@elasticmachine ok to test

…eries.

Add fuzzy_transpositions, fuzzy_prefix_length and fuzzy_max_expansions
parameters to simple_query_string query.
Add transpositions parameter to doc for fuzzy query
@alexshadow007
Copy link
Contributor Author

@jimczi Updated docs

@alexshadow007
Copy link
Contributor Author

@jimczi I also found that fuzzy query is using false as default value for transpositions. I can change it in another PR, what do you think about it?

@jimczi jimczi added :Search/Search Search-related issues that do not fall into other categories >feature v6.1.0 v7.0.0 labels Oct 5, 2017
@jimczi jimczi merged commit 9c95e91 into elastic:master Oct 5, 2017
@jimczi
Copy link
Contributor

jimczi commented Oct 5, 2017

Thanks @alexshadow007 ! I'll backport to 6.x shortly.
You can open another PR for the default value in the fuzzy query. I agree that it should be consistent but since it's a breaking change it should target 7.0 only.

jimczi pushed a commit that referenced this pull request Oct 5, 2017
Add fuzzy_transpositions parameter to multi_match and query_string queries.
Add fuzzy_transpositions, fuzzy_prefix_length and fuzzy_max_expansions
parameters to simple_query_string query.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Oct 6, 2017
* ccr: (42 commits)
  [DOCS] Added info about snapshotting your data before an upgrade.
  Add documentation about disabling `_field_names`. (elastic#26813)
  Remove UnsortedNumericDoubleValues (elastic#26817)
  Fix IndexOutOfBoundsException in histograms for NaN doubles (elastic#26787) (elastic#26856)
  [TEST] Added skipping the `headers` feature to the Bulk REST YAML test
  Update type-field.asciidoc
  Fix search_after with geo distance sorting (elastic#26891)
  Use proper logging placeholder for Netty logging
  Add Netty channel information on write and flush failure
  Remove deploying in JBoss documentation
  Document JVM option MaxFDLimit for macOS ()
  Add additional low-level logging handler ()
  Unwrap causes when maybe dying
  Change log level on write and flush failure to warn
  [TEST] add test to ensure legacy list syntax in yml works fine
  Bump BWC version for settings serialization to 6.1.0
  Removed void token filter entries and added two tests
  Added Bengali Analyzer to Elasticsearch with respect to the lucene update(PR#238)
  Fix toString() in SnapshotStatus (elastic#26852)
  elastic#26870 change bwc version for fuzzy_transpositions to 6.1 after backport
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>feature :Search/Search Search-related issues that do not fall into other categories v6.1.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose fuzzy_transpositions in fuzzy queries

4 participants