Fixes DesiredBalanceComputerTests Failure #135183
Open
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the threshold for convergence inside the DesiredBalanceComputerTests .testDesiredBalanceShouldConvergeInABigCluster from 1000 to 2000 since some tests had large numbers of shards, and the previous 1000 threshold was too restrictive. The test is also unmuted
joshua-adams-1
added
>non-issue
:Distributed Coordination/Distributed
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DiannaHohensee
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the threshold for convergence inside the
DesiredBalanceComputerTests .testDesiredBalanceShouldConvergeInABigClusterfrom 1000 to 2000 since some tests had large numbers of shards, and the previous 1000 threshold was too restrictive. The test is also unmuted.The specific test failure occurred when there were 7 nodes and 5460 shards, and it required 1090 iterations to converge. I have ran the test 10K+ times since and I didn't encounter a situation requiring >1100 iterations to converge, so 2000 has a nice safety buffer.
Closes #135123