[CI] LangPainlessClientYamlTestSuiteIT misses deprecation warnings

[markharwood]

Error in https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/1157/console

An expected warning message failed to appear:

did not get expected warning header [ getDate is no longer necessary on date fields as the value is now a date.

I took a look but it did not reproduce for me:

./gradlew :modules:lang-painless:integTestRunner -Dtests.seed=8E78B1E6509C9509 -Dtests.class=org.elasticsearch.painless.LangPainlessClientYamlTestSuiteIT -Dtests.method="test {yaml=painless/50_script_doc_values/date}"  -Dtests.security.manager=true -Dtests.locale=es-CR -Dtests.timezone=Europe/Kirov

Console output: https://gist.github.com/markharwood/40c99146e8e5ae2cf4361cdd1197c031

@nik9000 commented on the email:

Seems related to something that I did but happens infrequently. I'll dig when I'm done with what I'm working on now.

[nik9000]

It looks like this has only happened one other time:
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=fedora/647/console

Hunting!

[nik9000]

I can't reproduce and don't have any hints on how this happened. I'm going to set it down until it happens again.

[markharwood]

I thought one explanation might be the date warning wasn't actually missing but was misinterpreted by the test framework's result-parsing logic if there happened to be an additional warning.

To test that theory I tried changing the script to produce 2 deprecation warnings, one for a date and one for an integer :

source: "doc['date'].date +' '+ doc['integer'].date"

Sadly this didn't recreate the issue - the test reported both of the deprecation warnings as "unexpected" responses rather than reporting the date warning as "missing" as we saw in the original Jenkins failure.

[markharwood]

It looks like this has only happened one other time:

I found another from Feb 10th: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+openjdk-java9-periodic/74 but this was a missing warning for calling getDate on a long.

Did not reproduce:

./gradlew :modules:lang-painless:integTestRunner -Dtests.seed=370B6DEF0A627F3 -Dtests.class=org.elasticsearch.painless.LangPainlessClientYamlTestSuiteIT -Dtests.method="test {yaml=painless/50_script_doc_values/long}" -Dtests.security.manager=true -Dtests.locale=hu-HU -Dtests.timezone=Australia/LHI

[ywelsch]

more failures here: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+oracle-java10-periodic/171/console

[nik9000]

I shelled into the node that ran https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+oracle-java10-periodic/171/console and it did log the deprecation warning that the test claimed wasn't returned:

[2018-03-14T11:50:38,780][WARN ][o.e.d.i.f.ScriptDocValues$Dates] getDates is no longer necessary on date fields as the values are now dates.

So the error is somewhere between the deprecation logging and returning the deprecations. Weird!

[DaveCTurner]

Looking at the build-stats database I see the following failures that look like this (but none that pre-date 2018-02-07):

February  7th 2018, 21:44:13.596    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=fedora/647/
February  8th 2018, 14:54:48.391    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/1157/
February 10th 2018, 03:38:16.357    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+openjdk-java9-periodic/74/
February 22nd 2018, 11:37:36.089    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/1252/
February 23rd 2018, 10:17:20.589    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=debian/709/
February 28th 2018, 05:59:58.777    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=ubuntu/728/
March    14th 2018, 06:57:01.453    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=amazon/799/
March    14th 2018, 10:59:36.438    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+oracle-java10-periodic/171/
March    14th 2018, 13:05:25.079    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=fedora/800/
March    17th 2018, 15:57:33.428    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-java-periodic/ESJAVA=java10,ESRUNTIME=java9,nodes=linux/6/
March    21st 2018, 20:12:47.330    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+ccr-6.x+feature-branch-periodic/497/
March    21st 2018, 23:17:20.803    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=sles/829/
March    23rd 2018, 17:47:46.224    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/1420/
March    24th 2018, 18:53:30.134    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=oraclelinux/840/
March    26th 2018, 01:35:40.970    https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-windows-compatibility/845/

[davidkyle]

Another occurrence: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=fedora/887/console