-
Notifications
You must be signed in to change notification settings - Fork 115
Introduce UserDefinedObject
#5514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
063d015 to
705ebd2
Compare
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML UI: LGTM 🎉
|
@l-trotta @Anaethelion Would you be fine with backporting this to 8.19 and potentially 9.2? |
|
yep java resolves all aliases so this changes nothing for me |
|
Nope, we need proper handling for this first, this breaks the API badly. |
The specification uses
Dictionary<string, UserDefinedValue>in many places to indicate that the server returns an "arbitrary" JSON object.This PR introduces a new alias type
UserDefinedObjectthat should instead be used for this purpose, because: