Minor improvement to fix in #3018 #3031
Merged
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
improvement-to-3018
branch
from
c596227 to
0c1d8a7
Compare
miguelgrinberg
force-pushed
the
improvement-to-3018
branch
from
0c1d8a7 to
f14fb5f
Compare
This was referenced Aug 5, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Aug 5, 2025
(cherry picked from commit a67c2ee) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Aug 5, 2025
(cherry picked from commit a67c2ee) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Aug 5, 2025
(cherry picked from commit a67c2ee) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Aug 5, 2025
(cherry picked from commit a67c2ee) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Aug 5, 2025
(cherry picked from commit a67c2ee) Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I fixed #3018 I missed that the urllib3 client already had a retry configuration a few lines above. It makes more sense to configure the redirects in the same place.