Allow psr/log 2 #1154
Merged
Allow psr/log 2 #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
derrabus
force-pushed
the
bugfix/allow-psr-log-2
branch
from
6b44e98 to
d7dbe0f
Compare
|
Ping @ezimuel: this is a blocker for Seldaek/monolog#1564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables this library to be used with the updated
psr/loginterfaces. The current code is already compatible with version 2 of the interfaces.There's also a version 3, but unfortunately it requires a return type to be added to
Elasticsearch\Common\EmptyLogger. Adding that type could break userland code that extendsEmptyLogger.