Respect JSON Dates from Elasticsearch when passing to SourceSerializer #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the default Json.NET implementation when creating a JToken from a reader, will convert DateTimeOffset to local time with local offset. See JamesNK/Newtonsoft.Json#862. This is unwanted when passing off to the SourceSerializer. Closes #3164
Rider Refactoring removed this directive!
russcam
added a commit
that referenced
this pull request
Jun 7, 2018
#3278) * Respect JSON Dates from Elasticsearch when passing to SourceSerializer This commit fixes an issue where the default Json.NET implementation when creating a JToken from a reader, will convert DateTimeOffset to local time with local offset. See JamesNK/Newtonsoft.Json#862. This is unwanted when passing off to the SourceSerializer. Closes #3164 (cherry picked from commit ff2a867)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the default Json.NET implementation when
creating a JToken from a reader, will convert DateTimeOffset to local time with
local offset. See JamesNK/Newtonsoft.Json#862. This
is unwanted when passing off to the SourceSerializer.
Closes #3164