Feature/net abstractions backport 6.x #3266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE this also removes net45 support! * removed much of the framework and moved to Elastic.Xunit * deleted code now part of Elastic.Xunit and made everything compile again * readonly cluster tests are now working against Elastic.Xunit * update to Elastic.Xunit that fixed the test discovery * unit tests are back to green * plugin installation works again, readonly integration tests all good for netcore but wont run for net46 :/ * update to latest Elastic.Xunit and moved plugins to their dedicated clusters * writable cluster now needs analysis-phonetic too * readonly tests work again * make sure IntegrationSetup is called once * XPack integration tests are now green * add server validation callback for cluster clients * update to latest abstractions, rename machinelearning cluster, graphexplore should be on xpack cluster not readonly * Cluster and IntegrationTest Client consolidation. Cluster and IntegrationTestBase both expose a client, consolidate these to point to cluster's client. Make sure response.OriginalException is passed as inner exception to PipelineException * fixed most of the certificates cluster tests, client certificates is broken for now, will fix this over at Elastic.Managed.Ephemeral * Implemented the SkipTestAttributeBase implementations so that unit tests are all green again too * ProjectReferenceOnly did not listen to the right environment variable AppVeyr sets to indicate its testing the nuget packages, not the project reference * addressed review comments from @russcam Conflicts: build/Clients.Common.targets src/Tests/ClientConcepts/Certificates/WorkingWithCertificates.doc.cs src/Tests/ClientConcepts/HighLevel/Inference/Equality/FieldEqualityTests.cs src/Tests/ClientConcepts/HighLevel/Inference/Equality/FieldsEqualityTests.cs src/Tests/Document/Multiple/ReindexOnServer/ReindexOnServerRemoteApiTests.cs src/Tests/Framework/EndpointTests/ApiIntegrationTestBase.cs src/Tests/Framework/ManagedElasticsearch/Nodes/ElasticsearchNode.cs src/Tests/Framework/ManagedElasticsearch/Nodes/NodeFileSystem.cs src/Tests/Framework/ManagedElasticsearch/Plugins/ElasticsearchPluginCollection.cs src/Tests/Framework/ManagedElasticsearch/Plugins/ElasticsearchPluginConfiguration.cs src/Tests/Framework/ManagedElasticsearch/Process/XplatManualResetEvent.cs src/Tests/Framework/ManagedElasticsearch/Tasks/InstallationTasks/EnsureJavaHomeEnvironmentVariableIsSet.cs src/Tests/Framework/ManagedElasticsearch/Tasks/InstallationTasks/InstallationTaskBase.cs src/Tests/Framework/ManagedElasticsearch/Tasks/ValidationTasks/ValidateLicenseTask.cs src/Tests/Framework/TestClient.cs src/Tests/Framework/Xunit/NestTestFramework.cs src/Tests/Framework/Xunit/TestAssemblyRunner.cs src/Tests/Framework/Xunit/TestFrameworkExecutor.cs src/Tests/Program.cs src/Tests/Reproduce/ConnectionReuseAndBalancing.cs
Mpdreamz
changed the title
…licit net46 build
Contributor
|
This removes net45 support for 6.x? |
Mpdreamz
added a commit
that referenced
this pull request
Jun 22, 2018
…icsearchClientException, becuase its IConnection throws and that WebException is now preserved with the backport of #3266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE this also removes net45 support! backport of #3242 to
6.x