remove script file related API's and obsoleted Indexed on descriptors… #2933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Dec 13, 2017
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM. Left some comments around makring as Obsolete in 6.x, as opposed to removing and adding Obsolete attributes to 5.x
| public IndexedScriptDescriptor Id(string id) => new IndexedScriptDescriptor(id); | ||
|
|
||
| [Obsolete("Indexed() sets a property named id, this is confusing and thats why we intent to remove this in NEST 7.x please use Id()")] | ||
| public IndexedScriptDescriptor Indexed(string id) => new IndexedScriptDescriptor(id); |
Contributor
There was a problem hiding this comment.
Can we not just remove this and mark as [Obsolete] in 5.x?
|
|
||
| public IndexedScriptConditionDescriptor Id(string id) => new IndexedScriptConditionDescriptor(id); | ||
| [Obsolete("Indexed() sets a property named id, this is confusing and thats why we intent to remove this in NEST 7.x please use Id()")] | ||
| public IndexedScriptConditionDescriptor Indexed(string id) => new IndexedScriptConditionDescriptor(id); |
Contributor
There was a problem hiding this comment.
Can we not just remove this and mark as [Obsolete] in 5.x?
| public IndexedScriptConditionDescriptor Indexed(string id) => new IndexedScriptConditionDescriptor(id); | ||
|
|
||
| [Obsolete("Inline is being deprecated for Source and will be removed in Elasticsearch 7.0")] | ||
| public InlineScriptConditionDescriptor Inline(string script) => new InlineScriptConditionDescriptor(script); |
Contributor
There was a problem hiding this comment.
Can we not just remove this and mark as [Obsolete] in 5.x?
russcam
force-pushed
the
fix/file-scripts
branch
2 times, most recently
from
acda1e6 to
0c6ff23
Compare
russcam
force-pushed
the
fix/file-scripts
branch
from
0c6ff23 to
42e383a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in favor of Id